Skip to main content

Declaring VARCHAR without length

Do you find anything wrong with this script?

CREATE PROCEDURE uspProcedureName
      @param1 VARCHAR
AS
....
....

If you aren't sure may be you should read this post completely without fail :)

All this while I was thinking that it is a well known issue until last week I saw a stored procedure something similar to the one shown above. Who ever created that stored procedure hasn't bothered to specify the length. Before jumping into the explanation of why we should SPECIFY THE LENGTH ALWAYS let us do a small exercise to understand this better.

Guess the results:

Try to answer what would be the output before checking the result.

--Declaring a variable without specifying the length
DECLARE @strSentence VARCHAR
SET @strSentence = 'Rajinikanth is always the NO 1 hero of India'
SELECT @strSentence

Expected Output: Rajinikanth is always the NO 1 hero of India
Actual Output: R

--While CASTing / CONVERTing
--The given string has 36 characters.
SELECT CONVERT(VARCHAR, '123456789123456789123456789123456789');
SELECT CAST('123456789123456789123456789123456789' AS VARCHAR);

Expected Output: 123456789123456789123456789123456789
Actual Output: 123456789123456789123456789123

As you could see for Variables the default length for VARCHAR is 1. When used within CONVERT/CAST the default length for VARCHAR is 30. 

So if we don't specify the length ourself these are the default values SQL Server uses - which means the data what we would be expecting to get stored in the database would have got silently truncated without our knowledge. These are one such tricky issues which if we aren't aware would mean we have to spend hell a lot of time debugging our scripts at a later stage.

Now to answer the first question on what is wrong with this script let us create a sample table and a stored procedure similar to that and see what it does.

--Sample table
CREATE TABLE dbo.tblDemo
(
ID INT,
FirstName VARCHAR(30)
)
GO

--Stored Procedure to Insert data into the sample table
CREATE PROCEDURE dbo.uspInsertData
@ID INT,
@FName VARCHAR -- See there is no length specified here
AS
BEGIN
    SET NOCOUNT ON;
    INSERT INTO dbo.tblDemo VALUES (@ID, @FName)
END
GO

--Test
EXEC dbo.uspInsertData 10, 'Vadivel'
GO
SELECT ID, FirstName FROM dbo.tblDemo
GO

The output would be just 'V'. Once again the data has got truncated silently. So ALWAYS SPECIFY THE LENGTH OF THE STRING WITHOUT FAIL.


--Clean Up
DROP PROC dbo.uspInsertData;
DROP TABLE dbo.tblDemo;

Comments

pragadesh said…
Realy Useful Sir

Popular posts from this blog

Registry manipulation from SQL

Registry Manupulation from SQL Server is pretty easy. There are 4 extended stored procedure in SQL Server 2000 for the purpose of manupulating the server registry. They are: 1) xp_regwrite 2) xp_regread 3) xp_regdeletekey 4) xp_regdeletevalue Let us see each one of them in detail! About xp_regwrite This extended stored procedure helps us to create data item in the (server’s) registry and we could also create a new key. Usage: We must specify the root key with the @rootkey parameter and an individual key with the @key parameter. Please note that if the key doesn’t exist (without any warnnig) it would be created in the registry. The @value_name parameter designates the data item and the @type the type of the data item. Valid data item types include REG_SZ and REG_DWORD . The last parameter is the @value parameter, which assigns a value to the data item. Let us now see an example which would add a new key called " TestKey ", and a new data item under it called TestKeyValue :

Screen scraping using XmlHttp and Vbscript ...

I wrote a small program for screen scraping any sites using XmlHttp object and VBScript. I know I haven't done any rocket science :) still I thought of sharing the code with you all. XmlHttp -- E x tensible M arkup L anguage H ypertext T ransfer P rotocol An advantage is that - the XmlHttp object queries the server and retrieve the latest information without reloading the page. Source code: < html > < head > < script language ="vbscript"> Dim objXmlHttp Set objXmlHttp = CreateObject("Msxml2.XMLHttp") Function ScreenScrapping() URL == "UR site URL comes here" objXmlHttp.Open "POST", url, False objXmlHttp.onreadystatechange = getref("HandleStateChange") objXmlHttp.Send End Function Function HandleStateChange() If (ObjXmlHttp.readyState = 4) Then msgbox "Screenscrapping completed .." divShowContent.innerHtml = objXmlHttp.responseText End If End Function </ script > < head > < body > &l

Script table as - ALTER TO is greyed out - SQL SERVER

One of my office colleague recently asked me why we are not able to generate ALTER Table script from SSMS. If we right click on the table and choose "Script Table As"  ALTER To option would be disabled or Greyed out. Is it a bug? No it isn't a bug. ALTER To is there to be used for generating modified script of Stored Procedure, Functions, Views, Triggers etc., and NOT for Tables. For generating ALTER Table script there is an work around. Right click on the table, choose "Modify" and enter into the design mode. Make what ever changes you want to make and WITHOUT saving it right click anywhere on the top half of the window (above Column properties) and choose "Generate Change Script". Please be advised that SQL Server would drop actually create a new table with modifications, move the data from the old table into it and then drop the old table. Sounds simple but assume you have a very large table for which you want to do this! Then it woul